Closed
Bug 1547211
Opened 5 years ago
Closed 5 years ago
Better fallback states for DS for offline mode
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | verified |
People
(Reporter: andreio, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
If I start a profile with DS enabled but no internet connection we throw some unexpected errors
Failed to fetch https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?topic_id=1&duration=2592000&end_time_offset=172800&version=3&consumer_key=40249-e88c401e1b1f2242d9e441c4&locale_lang=en-US&feed_variant=OptimalCuratedLinksForLocaleFeed&model_id=external_time_live: NetworkError when attempting to fetch resource. DiscoveryStreamFeed.jsm:124
No response for feed DiscoveryStreamFeed.jsm:564
Error trying to load component feed https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?topic_id=1&duration=2592000&end_time_offset=172800&version=3&consumer_key=$apiKey&locale_lang=en-US&feed_variant=OptimalCuratedLinksForLocaleFeed&model_id=external_time_live: TypeError: feed is null DiscoveryStreamFeed.jsm:259
Error trying to load component feeds: TypeError: newFeeds[currentValue] is null DiscoveryStreamFeed.jsm:606
And if I then enable the internet connection we don't do a retry but wait for the next system tick.
Also attached in the screenshot if the feed is loaded but then I lose connectivity the images show a "broken loaded state".
Updated•5 years ago
|
Iteration: --- → 68.4 - Apr 29 - May 12
Priority: -- → P1
Updated•5 years ago
|
Assignee: nobody → gsuntop
Comment 1•5 years ago
|
||
topstories used css background-image while the discoverystream uses <picture>/<img>
(resulting in the error icon) so might need to add an onerror handler here
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Comment 4•5 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190506214617) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "broken loaded state" is no longer displayed on the images anymore.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•