Closed Bug 1547322 Opened 6 years ago Closed 6 years ago

dialogOverlay have to 2 close buttons

Categories

(Firefox :: Settings UI, defect)

54 Branch
Unspecified
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: vladikoff, Assigned: aswan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image dialog.png (deleted) —

STR

  • Open about:preferences#privacy
  • click on "Manage Exceptions"

Expected

Single [X] to close the dialog

Actual

It has 2 close buttons

Details

On Mac OS as of 68.0a1 (2019-04-26) (64-bit)
This affects other dialogs, not just the one in the privacy section. For example the Firefox Sync "Disconnect" dialog.

Regressed by: 1538983
Keywords: regression

Thanks for filing. Will have a fix in https://phabricator.services.mozilla.com/D29063.

Assignee: nobody → aswan
Status: NEW → ASSIGNED
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/013a4420b53c Don't double-insert inner content when <button> is cloned r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: