Closed Bug 1548268 Opened 6 years ago Closed 6 years ago

Improve accessibility of trailhead flow

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

  • turn on linter (bug 1511152)
  • aria-hidden=true for content behind modal
  • keep tabbing focus inside modal
  • automatically focus email input
  • role=dialog on modal with aria-labelledby=<id of heading>
  • allow keyboard escape from dialog (bug 1548267)

I'm also happy to look at it again in more detail once things on the list are addressed.

In the meanwhile, just like with dialog semantics I would also generally pay attention to semantics of other widgets/controls/etc within the new UI and text alternatives for non-textual bits where needed.

Depends on: 1548267
Assignee: nobody → edilee
Priority: -- → P1

FYI, I looked at colour contrast and there are no issues with onboarding dialog or the cards that show up after it's dismissed.

Blocks: 1549863
Status: NEW → RESOLVED
Iteration: --- → 68.4 - Apr 29 - May 12
Closed: 6 years ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Blocks: 1550642

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190509214305) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the "First Run" page elements are respecting the specs from comment 0.

Status: RESOLVED → VERIFIED
Blocks: 1511152
No longer depends on: 1511152

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified

Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: