Closed
Bug 1548927
Opened 6 years ago
Closed 6 years ago
[de-xbl] convert the menuitem-iconic-desc-noaccel binding
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
The menuitem-iconic-desc-noaccel binding can now be converted since bug 1500626 is now done.
The binding has very little use, so will have to investigate what to do about it.
|
Assignee | |
Comment 1•6 years ago
|
||
In the compose window this is the element which is showing the account name to which the identity belongs.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9063452 -
Flags: review?(alessandro)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9063452 [details] [diff] [review]
bug1548927_menuitem_desc_noaccel.patch
Review of attachment 9063452 [details] [diff] [review]:
-----------------------------------------------------------------
Looks perfect, tested also on macos.
Do you think would be better to update the commit message with r=aleca instead of r=alex in order to match my account name?
Attachment #9063452 -
Flags: review?(alessandro) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7363a3e2cfb9
[de-xbl] convert usage of the menuitem-iconic-desc-noaccel binding. r=aleca
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•