Closed Bug 1548927 Opened 5 years ago Closed 5 years ago

[de-xbl] convert the menuitem-iconic-desc-noaccel binding

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

The menuitem-iconic-desc-noaccel binding can now be converted since bug 1500626 is now done.

https://searchfox.org/comm-central/rev/348181b147e1699111add8dbb73991fd625ce28b/mail/base/content/mailWidgets.xml#596

The binding has very little use, so will have to investigate what to do about it.

Blocks: 1549357
Attached patch bug1548927_menuitem_desc_noaccel.patch (deleted) β€” β€” Splinter Review

In the compose window this is the element which is showing the account name to which the identity belongs.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9063452 - Flags: review?(alessandro)
Comment on attachment 9063452 [details] [diff] [review]
bug1548927_menuitem_desc_noaccel.patch

Review of attachment 9063452 [details] [diff] [review]:
-----------------------------------------------------------------

Looks perfect, tested also on macos.
Do you think would be better to update the commit message with r=aleca instead of r=alex in order to match my account name?
Attachment #9063452 - Flags: review?(alessandro) → review+

Yes, I've changed r=alex to r=aleca before.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7363a3e2cfb9
[de-xbl] convert usage of the menuitem-iconic-desc-noaccel binding. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: