Update browser_ tests for plugin blocking in browser/base/content/ and toolkit/mozapps/extensions/test/browser to work with the non-xml remote settings implementation of the blocklist
Categories
(Toolkit :: Blocklist Implementation, task, P1)
Tracking
()
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In bug 1257565 I'll make them forcibly use the XML version. For the future, we need to make sure the tests work with the remote settings version.
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Note to self: bug 1129040 removed the users of plugin_clickToPlayAllow.html and -Deny.html, but left the files.
Assignee | ||
Comment 2•5 years ago
|
||
Ditto browser/base/content/test/plugins/plugin_test3.html
Assignee | ||
Comment 3•5 years ago
|
||
Annnnd bug 1307445 removed the only consumer of dom/base/test/chrome/blockNoPlugins.xml without removing that.
Assignee | ||
Comment 4•5 years ago
|
||
Try looks OK though somehow macOS tests are slow to run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=841a34729dfcfae1f2f418d81c3e4f2f3f5d3db4
Assignee | ||
Comment 5•5 years ago
|
||
Comment 7•5 years ago
|
||
bugherder |
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley
Beta/Release Uplift Approval Request
- User impact if declined: Missing test coverage on plugins and the remote settings blocklist on 68.
Note: please also consider this a request for the esr68 branch as well, for which it seems there is no bmo flag yet.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Automated tests only.
- String changes made/needed: nope
Assignee | ||
Comment 9•5 years ago
|
||
Ritu, I don't see an esr68 approval flag, so needinfo'ing you just in case. :-)
Thanks Gijs! Hey Jcristau, are beta uplifts automatically uplifted to esr68? Just want to make sure this fix doesn't miss uplift to ESR68.
Comment 11•5 years ago
|
||
I believe beta will be merged to esr68 at least up until the July 1 merge day.
Comment 12•5 years ago
|
||
Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley
this is test-only so doesn't require release mgmt approval
Updated•5 years ago
|
Comment 13•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Description
•