Reload the page when calling Page.navigate with the current document URI
Categories
(Remote Protocol :: CDP, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: ochameau, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
This behavior is expected when running the wordpress test suite.
|
Reporter | |
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
Alex, I started adding a test case for this, but locally it passes just fine without any implementation change. Is there another test case I can use to check the issue? You can see my test at: https://hg.mozilla.org/try/rev/7adf3dcf5f96dbaf5a29dbed42aff1e9df1ab3cb
|
|
Reporter | |
Comment 3•6 years ago
|
||
The test case was a Gutenberg test (packages/e2e-tests/specs/preferences.test.js). When I opened this bug, the page wasn't reloading, or I wasn't receiving all the expected Page/Runtime events. Bug 1548102 may have fixed that...
I confirm what you are seeing and this implementation change is no longer necessary. The Gutenberg test now pass without this "fix".
Anyway, the added test is still useful to ensure that we do not regress that, as it was important for the gutenberg test to pass!
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
Thanks for the feedback!
As discussed, here is a patch for the updated test. I kept the implementation as is, but if you think we don't need the complexity of checking that the page was reloading by checking the content (ie, if we can rely on the events only), I will be happy to update it to only test that the events are triggered as expected when we call the navigate API.
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•