Favicons on each LoginListItem and on the LoginItem
Categories
(Toolkit :: Password Manager, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | verified |
People
(Reporter: jaws, Assigned: lnorton)
References
()
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Each LoginListItem should include the favicon for the site to the left of the hostname and username (flipped for RTL), vertically centered.
The LoginItem should also include the favicon before the title.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Comment 5•5 years ago
|
||
Backed out changeset de47b64c35f1 (bug 1549808) for failing at browser_masterPassword.js on a CLOSED TREE.
Backout link: https://hg.mozilla.org/integration/autoland/rev/ed9932cd52fe01a2f346e15400bdb5b9f3d0d262
**Push with failures:**https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=de47b64c35f1c2ae403562225933f87a6f352c68&selectedJob=259232325
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259232325&repo=autoland&lineNumber=20670
Log snippet:
[task 2019-07-31T18:19:20.099Z] 18:19:20 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | Dialog is the Master Password dialog -
[task 2019-07-31T18:19:20.099Z] 18:19:20 INFO - Console message: [JavaScript Error: "Error: Unexpected event type" {file: "chrome://formautofill/content/FormAutofillFrameScript.js" line: 86}]
[task 2019-07-31T18:19:20.099Z] 18:19:20 INFO - Master Password dialog shown and authenticated
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - Console message: [JavaScript Error: "Security Error: Content at about:logins may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg."]
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - Console message: [JavaScript Error: "Security Error: Content at about:logins may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg."]
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - Buffered messages finished
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | reveal checkbox should be checked if MP dialog authenticated - false == true -
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - Stack trace:
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - resource://testing-common/content-task.js line 62 > eval:null:8
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - resource://testing-common/content-task.js:null:63
[task 2019-07-31T18:19:20.100Z] 18:19:20 INFO - Leaving test bound test
[task 2019-07-31T18:19:20.101Z] 18:19:20 INFO - GECKO(5888) | MP change from omgsecret! to
Comment 7•5 years ago
|
||
bugherder |
Reporter | ||
Updated•5 years ago
|
Comment 8•5 years ago
|
||
I have verified this issue on the latest Nightly 70.0a1 (2019-08-08) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04.
- The favicons are displayed on each login from the "Login List" and on the Login Item on the left side of the title.
Description
•