Implement DOM mutation breakpoint UX for inspector markup view
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox71 fixed)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: Honza, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-reserve])
Attachments
(2 files)
When adding a DOM Breakpoint in the Inspector, I want to see an indicator in the markup view, so that I have visual confirmation and an easy way to remove it.
Honza
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Mockup link (in progress - feedback wanted)
|
||
Comment 3•5 years ago
|
||
This might rely on new server APIs introduced in Bug 1550835. Please test backward compatibility when working on this or ping me for review. Thanks!
|
|
Assignee | |
Comment 4•5 years ago
|
||
This implements the context menu items for the DOM mutation breakpoint.
In addition, there were some server changes to:
- Update the mutationBreakpoints form for the NodeActor
- Expose the mutationBreakpoints form
- Moved the setMutationBreakpoints method from the Node spec to Walker spec
since the Node spec only consisted of getter methods. It made more sense
that the setter went into the Walker spec to be more consistent with how
the Walker and Node spec have been arranged.
Unit tests will be followed up in Part 2 immediately.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb51bb3f412 Part 1: Implement the DOM mutation breakpoint context menu items in the markup view. r=loganfsmyth,jdescottes
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Comment 7•5 years ago
|
||
Can this be closed with Gabriel's patch?
|
|
Assignee | |
Comment 8•5 years ago
|
||
(In reply to David Walsh :davidwalsh from comment #7)
Can this be closed with Gabriel's patch?
Yea, I left it open so I could add some unit tests for it, but that can always go in a new bug.
|
|
||
Comment 9•5 years ago
|
||
Ah, I actually hadn't finalized the gutter icon design work yet - is that not what this bug is about?
|
|
Assignee | |
Comment 10•5 years ago
|
||
(In reply to Victoria Wang [:victoria] from comment #9)
Ah, I actually hadn't finalized the gutter icon design work yet - is that not what this bug is about?
Ah yes, I guess we should probably rename and close this bug and spawn new bugs for the new work since we ended up using this bug for implementing the context menu.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 11•5 years ago
|
||
|
||
Comment 12•5 years ago
|
||
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/284c86226071 Show breakpoint icon in inspector for DOM Mutation Breakpoints r=gl
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 14•5 years ago
|
||
Looks like all work related to this landed.
|
||
Updated•5 years ago
|
Description
•