Move global keyboard shortcut handling outside of XBL.
Categories
(Core :: XBL, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Currently code inside the XBL directory is responsible for handling keyboard shortcut handlers defined by XBL, keyboard shortcut handlers defined by XUL <key> elements. And some global keyboard shortcut handlers defined in dom/xbl/builtin.
The majority of this code isn't XBL specific at all. I'm experimenting with ripping out the shared pieces into dom/events and just having XBL handlers extend that instead.
This should make it easier to remove support for XBL.
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Here is an overview of the plan I want to follow. This bug covers part 1.
https://docs.google.com/document/d/1_Z2P5LeISwXt7JKuS9rKJkJg-ubWbMWUIMXPnbBrywg/
Assignee | ||
Comment 2•5 years ago
|
||
Most of our keyboard shortcut handling is handled by nsXBLWindowKeyHandler along
with nsXBLPrototypeHandler. With the impending removal of XBL this needs to
change.
This patch moves nsXBLWindowKeyHandler to dom/events/GlobalKeyListener and copies
nsXBLPrototypeHandler to dom/events/KeyEventHandler. Windows, text elements and
XUL <keyset> are changed to use the new copies and anything unnecessary for
those is stripped out.
XBL handler elements still remain using the existing nsXBLPrototypeHandler path.
Some of the code is ripped out there to make it compile. There is probably a
lot more that can be removed but since the whole of XBL is likely gone soon I'm
not sure it is worth cleaning that up much.
Comment 3•5 years ago
|
||
smaug: Could you check the strategy of the new directory and class names which I asked from Phabricator.
Updated•5 years ago
|
Comment 6•5 years ago
|
||
Backed out for Android build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265186274&repo=autoland&lineNumber=27083
Backout: https://hg.mozilla.org/integration/autoland/rev/65ad92a24f8bfaccd877559118778ee3aac50ef5
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•