Link users to the login they are duplicating in the error message
Categories
(Firefox :: about:logins, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | disabled |
firefox70 | --- | verified |
firefox71 | --- | verified |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline] [strings])
Attachments
(3 files)
When a user creates a login, we should check that the hostname, username, and password are not already present in the storage (with a wildcard formSubmitURL).
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment hidden (obsolete) |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
This can be implemented without adding new strings by just linking the current error message to the existing login.
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c3082c1a8f7b
https://hg.mozilla.org/mozilla-central/rev/ea553ba219cd
https://hg.mozilla.org/mozilla-central/rev/d3e85469f539
Comment 8•5 years ago
|
||
I have verified this issue on the latest Nightly (Build ID: 20191003214801) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.
- The “Go to existing entry? “ link is displayed in the error message.
- The existing login is focused after clicking on the “Got to existing entry” link and discard the changes.
- The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.
Leaving this to ride with 71 (because of the string change) after discussing with jaws
Assignee | ||
Comment 10•5 years ago
|
||
bugherder uplift |
Now with fewer string changes!
And ok for jaws' batch uplift.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 13•5 years ago
|
||
I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.
- The error message is hyperlinked.
- The existing login is focused after clicking on the error message link and discard the changes.
- The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.
Description
•