The copy-to-clipboard element should be placed adjacent to the username and password in the LoginItem. Each time it is used we should record an telemetry event.

Backed out 4 changesets (Bug 1550093) for browser_parsable_css.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cshippable%2Copt%2Cmochitests%2Ctest-linux32-shippable%2Fopt-mochitest-browser-chrome-e10s&fromchange=9e5d3e59a35e2e50bf3b684368c636d2d833c920&tochange=366a49e70140c78e213fe86b7616e2c8c88fc906&selectedJob=247138811

Backout link: https://hg.mozilla.org/integration/autoland/rev/366a49e70140c78e213fe86b7616e2c8c88fc906

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247138811&repo=autoland&lineNumber=2405

[task 2019-05-17T23:32:41.474Z] 23:32:41 INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js
[task 2019-05-17T23:32:42.379Z] 23:32:42 INFO - GECKO(2837) | [Parent 2837, Main Thread] WARNING: Error loading theme icon 'dialog-warning' for stock: Icon 'dialog-warning' not present in theme ubuntu-mono-dark: 'glib warning', file /builds/worker/workspace/build/src/toolkit/xre/nsSigHandlers.cpp, line 135
[task 2019-05-17T23:32:42.380Z] 23:32:42 INFO - GECKO(2837) | (firefox:2837): Gtk-WARNING **: Error loading theme icon 'dialog-warning' for stock: Icon 'dialog-warning' not present in theme ubuntu-mono-dark
[task 2019-05-17T23:32:42.381Z] 23:32:42 INFO - GECKO(2837) | [Parent 2837, Main Thread] WARNING: Error loading theme icon 'dialog-information' for stock: Icon 'dialog-information' not present in theme ubuntu-mono-dark: 'glib warning', file /builds/worker/workspace/build/src/toolkit/xre/nsSigHandlers.cpp, line 135
[task 2019-05-17T23:32:42.383Z] 23:32:42 INFO - GECKO(2837) | (firefox:2837): Gtk-WARNING **: Error loading theme icon 'dialog-information' for stock: Icon 'dialog-information' not present in theme ubuntu-mono-dark
...
[task 2019-05-17T23:32:43.255Z] 23:32:43 INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’. Declaration dropped." {file: "resource://pdf.js/web/viewer.css?always-parse-css-0.5005887437900381" line: 1534}]
[task 2019-05-17T23:32:43.256Z] 23:32:43 INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’. Declaration dropped." {file: "resource://pdf.js/web/viewer.css?always-parse-css-0.5005887437900381" line: 1568}]
[task 2019-05-17T23:32:43.258Z] 23:32:43 INFO - Buffered messages finished
[task 2019-05-17T23:32:43.259Z] 23:32:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property --messsage-bar-icon-url is not referenced -
[task 2019-05-17T23:32:43.261Z] 23:32:43 INFO - Stack trace:
[task 2019-05-17T23:32:43.262Z] 23:32:43 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
[task 2019-05-17T23:32:43.264Z] 23:32:43 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:453
[task 2019-05-17T23:32:43.265Z] 23:32:43 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-05-17T23:32:43.267Z] 23:32:43 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-05-17T23:32:43.268Z] 23:32:43 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-05-17T23:32:43.271Z] 23:32:43 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-05-17T23:32:43.272Z] 23:32:43 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-has-dir-attr’. Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua|pluginproblem)\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}

https://hg.mozilla.org/mozilla-central/rev/6bd4c5122a6a
https://hg.mozilla.org/mozilla-central/rev/f764dd06add4
https://hg.mozilla.org/mozilla-central/rev/c5515eb04c11
https://hg.mozilla.org/mozilla-central/rev/cfa094f6fd3a

A testcase or more details on how to verify this fix would really be useful here.

(In reply to Adrian Florinescu [:adrian_sv] from comment #9)

A testcase or more details on how to verify this fix would really be useful here.

1. Make sure you have some logins stored in Firefox
2. Make sure you have signon.management.page.enabled=true in about:config
3. Open about:logins
4. Click on a login in the list on the left side of the page
5. Click on the "Copy" button in the Username row of the login
6. The username should be in the clipboard and you can paste it somewhere to verify.
7. Click on the "Copy" button in the Password row of the login
8. The password should be in the clipboard and you can paste it somewhere to verify.

When clicking the "Copy" button, the button should be replaced by text that reads "Copied" with a checkmark, and the button should reappear 5 seconds later.

The comment 0 also states that a telemetry event should be generated each time copy is used, it'd probably be nice to have that listed and verified as well.

Telemetry events are still waiting on bug 1549115. I'll comment in that bug to make sure to include the Copy event as part of that initial work.

This issue is Verified as fixed in Fx Beta 68.0b13 on Windows 10, Ubuntu and Mac OsX.