Closed Bug 1550109 Opened 6 years ago Closed 5 years ago

HTML validation, required fields, regex for website address

Categories

(Firefox :: about:logins, enhancement, P1)

Product:
Firefox
Component:
about:logins
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline] )

Attachments

(4 files)

Bug 1550109 - Add default styling for input[type=url] to common.inc.css. r?MattN
(deleted), text/x-phabricator-request
Details
Bug 1550109 - Add support for required modal-input values. r?MattN
(deleted), text/x-phabricator-request
Details
Bug 1550109 - Require the origin and password when creating a new login. r?MattN
(deleted), text/x-phabricator-request
Details
Bug 1550109 - Add tests for required fields of the login-item. r?MattN
(deleted), text/x-phabricator-request
Details

Editing a LoginItem should have basic validation of the hostname, username, and password. We should require that all fields are filled. Hostnames should validate as a URL object.

Flags: qe-verify+
Type: task → enhancement
<input type="url" required>

would be a good starting point for origin validation… it doesn't seem to require a trailing slash which is good.

Assignee: nobody → jaws
Status: NEW → ASSIGNED

Validation constraints and errors need to be surfaced still. Some of this work could be pushed to bug 1550122.

Attachment #9066605 - Attachment description: Bug 1550109 - (WIP) Require the origin and password when creating a new login. r?MattN → Bug 1550109 - Require the origin and password when creating a new login. r?MattN
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30ce578fc33c Add default styling for input[type=url] to common.inc.css. r=MattN https://hg.mozilla.org/integration/autoland/rev/f51914dc71e3 Add support for required modal-input values. r=MattN https://hg.mozilla.org/integration/autoland/rev/e292d1c1e2f1 Require the origin and password when creating a new login. r=MattN,Pike https://hg.mozilla.org/integration/autoland/rev/a121178c0634 Add tests for required fields of the login-item. r=MattN

Hi Jared Wein,

Could you please tell me the steps to reproduce the bug, please?

Thanks in advance, Flor.

Flags: needinfo?(jaws)
Depends on: 1556934

Work in this area is still too early for QE verification.

Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(jaws)
Flags: in-testsuite+
Whiteboard: [passwords:management] [skyline]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: