Closed Bug 1550496 Opened 6 years ago Closed 5 years ago

2.05% displaylist_mutate (linux64-shippable-qr) regression on push 34510ca46cc61984ca775f30a7c4f288371cf329 (Mon May 6 2019)

Categories

(Core :: Graphics: WebRender, defect, P3)

68 Branch
Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: igoldan, Assigned: aosmond)

References

(Regression)

Details

(4 keywords)

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5772a92c49cf6cc746fe0d22a797fe3f08a20f39&tochange=34510ca46cc61984ca775f30a7c4f288371cf329

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

2% displaylist_mutate linux64-shippable-qr opt e10s stylo 3,756.75 -> 3,833.60

Improvements:

3% sessionrestore linux64-shippable-qr opt e10s stylo 954.46 -> 926.17
2% startup_about_home_paint linux64-shippable-qr opt e10s stylo 1,211.38 -> 1,184.33

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=20873

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Component: General → Graphics: WebRender
Product: Testing → Core
Flags: needinfo?(aosmond)
Priority: -- → P3

The scene builder threads don't seem to have any samples, that is where most of the code I changed should be running. I'm not very concerned about this regression, I assumed there was a possibility for a small regression, given we do more calculations when building the picture tree, but that is unavoidable for correctness purposes.

Flags: needinfo?(aosmond)

(In reply to Andrew Osmond [:aosmond] from comment #2)

The scene builder threads don't seem to have any samples, that is where most of the code I changed should be running. I'm not very concerned about this regression, I assumed there was a possibility for a small regression, given we do more calculations when building the picture tree, but that is unavoidable for correctness purposes.

So we close this as WONTFIX, then?

Flags: needinfo?(aosmond)

This regression may go away with bug 1574493 given I've removed a lot of the code I added before, and we are doing overall less work to perform snapping.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → aosmond
Flags: needinfo?(aosmond)
Target Milestone: --- → mozilla71
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.