Closed Bug 1550694 Opened 5 years ago Closed 5 years ago

OTR: Consider to move all strings to a single file.

Categories

(Chat Core :: Security: OTR, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: KaiE, Unassigned)

References

Details

Follow-up from review of bug 1518172.

Discuss if we should move all OTR strings into single dtd/properties files.

Patrick, with the conversion to fluent, each pair of {dtd, properties} was merged into a combined ftl file.

Would you be OK keeping the individual files, with some of them being directly related to dialogs?

Flags: needinfo?(clokep)

For reference, bug 1550488 changed this code to use fluent.

(In reply to Kai Engert (:kaie:) from comment #1)

Would you be OK keeping the individual files, with some of them being directly related to dialogs?

If each dialog usually has a separate file then that's fine.

Flags: needinfo?(clokep)

We have 7 ftl files. 4 are for OTR dialogs. 1 is for the global account prefs. So we're down to two files, and those are used by the separate OTR.jsm and OTRUI.jsm modules.

Based on Patrick's comment, IIUC this should be acceptable.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
Component: General → Security: OTR
You need to log in before you can comment on or make changes to this bug.