Closed Bug 1550801 Opened 6 years ago Closed 5 years ago

Load all XUL as XHTML

Categories

(Core :: XUL, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

(Depends on 2 open bugs)

Details

Attachments

(2 files)

As one of the first steps of removing XULDocument we can start loading all XUL files as XHTML first.

There are a few thing we'll need to update:

  1. Anything that references XULDocument
  2. All createElement calls will need to be converted to createXULElement
Depends on: 1551320
Depends on: 1551344
Type: defect → task
Depends on: 1557371
Depends on: 1558613
Depends on: 1558674
Depends on: 1558686
Depends on: 1558693
Depends on: 1558704
Depends on: 1558980
Depends on: 1559008
Depends on: 1559194
Depends on: 1559463
Depends on: 1567352
Depends on: 1567558

Now that the functionality we we wanted to preserve has been moved out of
XULDocument, we can start loading XUL files as XHTML. This will allow
the removal of XULDocument once we are confident that everything is working
correctly as XHTML.

test_bug819670_getter_throws.html:
Previously, the document context inspected in the console was the test
harness XULDocument, but now it will be an HTMLDocument. Update the
checks to make sure the inspected object has the same own properties as
the test documents own properties.

other tests:
Simply replace the expected document type.

Depends on D38694

For some extra testing, I pushed up a try run where for reftests I load one document as XHTML and one as XUL to ensure there were no regressions.

Assignee: nobody → bdahl
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd2b93ff0abe Load XUL documents as XHTML documents. r=smaug https://hg.mozilla.org/integration/autoland/rev/4f0e19e164f1 Replace expected XULDocument with HTMLDocument in devtools tests. r=nchevobbe
No longer depends on: 1551344
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1575620
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: