Closed
Bug 1551110
Opened 6 years ago
Closed 6 years ago
testEventDialog failing with TypeError: this.getListItem(...) is undefined
Categories
(Calendar :: Dialogs, defect)
Calendar
Dialogs
Tracking
(Not tracked)
RESOLVED
FIXED
68
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
JavaScript error: chrome://calendar/content/calendar-event-dialog-attendees-custom-elements.js, line 1181: TypeError: this.getListItem(...) is undefined
I don't understand why this error only appears on Windows, or why it seems to only happen between 0800 and 1400 UTC, but I can stop it happening.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9064346 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 2•6 years ago
|
||
There are some things I do know that I forgot to mention:
- This failure appears to have started when the attendees dialog widgets were converted to custom elements at bug 1522473, although there was so much other carnage going on then it's hard to tell.
- It looks like when the bug occurs the code in
get attendeesis callingthis.getInputElement(4)and there are not 4 rows. There should be four rows so I thinkfitDummyRowsisn't called. But why?
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b39e405810ed
In attendees dialog, stop trying to use rows that don't exist; rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → 7.0
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9064346 [details] [diff] [review]
1551110-getlistitem-1.diff
Review of attachment 9064346 [details] [diff] [review]:
-----------------------------------------------------------------
Maybe also use querySelector in the last part of the patch? (Sorry, line comments are broken on mobile)
Attachment #9064346 -
Flags: review?(philipp) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•