Add pc.restartIce() method.
Categories
(Core :: WebRTC, enhancement, P2)
Tracking
()
People
(Reporter: jib, Assigned: jib)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
Add proposed restartIce()
method to RTCPeerConnection
behind a pref, to meet commitment.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 3•6 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 4•6 years ago
|
||
Since these patches contain wpt tests (which would get upstreamed), I'm holding off until a June 11th webrtc interim where this feature will be discussed.
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Spec PR merged, so this can land without pref.
Assignee | ||
Updated•5 years ago
|
Would increasing the number of test chunks help with the fd issue?
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/web-platform.yml#47
Assignee | ||
Comment 7•5 years ago
|
||
Added https://github.com/w3c/webrtc-pc/pull/2231 for latest change.
Depending on what's opening files, you could also try adding "restart-after" to the metadata for some webrtc tests.
Docs:
A key ``restart-after`` which can be set to any value to indicate that
the runner should restart the browser after running this test (e.g. to
clear out unwanted state).
Assignee | ||
Comment 10•5 years ago
|
||
Bumping the number of chunks appears not to have worked (though there's no stack, so I've re-run it a few times to get one just in case):
[task 2019-07-17T03:37:26.321Z] 03:37:26 INFO - IOError on command, setting status to CRASH
[task 2019-07-17T03:37:26.538Z] 03:37:26 INFO - TEST-UNEXPECTED-CRASH | /webrtc/RTCPeerConnection-setRemoteDescription-rollback.html | expected OK
The newly added test is 10 tests prior to this crash. Will try a restart-after
somewhere in the middle, thanks!
Assignee | ||
Comment 11•5 years ago
|
||
Trying restart-after
.
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
:jib - when the time comes, please be sure to also add dev-doc-needed to any follow-up bugs around enabling this on various channels, or by default. Thanks!
Assignee | ||
Comment 16•5 years ago
|
||
This is already enabled, not behind a pref. Riding the trains.
Comment 17•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7e047766fccd
https://hg.mozilla.org/mozilla-central/rev/1e8389cdefd3
Comment 18•5 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Comment 20•5 years ago
|
||
Documentation is up to date:
- RTCPeerConnection.restartIce()
- BCD update PR has been submitted to set the compatibility versions for Firefox and Chrome
Firefox 70 for developers was already updated by Chris.
Description
•