Closed Bug 1551588 Opened 5 years ago Closed 5 years ago

The "circled i" and "Dismiss" buttons from the "FxA Bookmark Panel Message" are inaccessible through keyboard navigation

Categories

(Firefox :: Messaging System, defect, P3)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox66 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- verified

People

(Reporter: mcoman, Assigned: emcminn)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

rec of the issue.gif
(deleted), image/gif
Details
Bug 1551588 - Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message
(deleted), text/x-phabricator-request
Details
Attached image rec of the issue.gif (deleted) —

[Affected versions]:

  • Firefox Beta 68.0b1, Build ID 20190513111358
  • Firefox Nightly 68.0a1, Build ID 20190514094236

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref's value set to "true" in the "about:config" page.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Navigate to any website and click the "Bookmark this page" button from the right part of the "Address Bar".
  3. Press the "Tab" key 8 times and observe the behavior.

[Expected result]:

  • The "circled i" button is focused.

[Actual result]:

  • The "FxA Bookmark Panel Message" is focused.

[Notes]:

  • If, after following the steps from above, the "Tab" key is pressed for one more time, the "Name" text input field is focused instead of the "X" button.
  • Attached a screen recording of the issue.
Iteration: --- → 69.1 - May 13 - 26
status-firefox69: --- → affected
Priority: -- → P2
Blocks: 1554739
Iteration: 69.1 - May 13 - 26 → 69.2 - May 27 - Jun 9
Iteration: 69.2 - May 27 - Jun 9 → ---
status-firefox68: affected → wontfix
status-firefox69: affected → wontfix
Priority: P2 → P3
Blocks: cfr
No longer blocks: 1541914
Component: Activity Streams: Newtab → Messaging System
Assignee: nobody → emcminn
Attachment #9086766 - Attachment description: Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message → Bug 1551588 - Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/089d52d6ad36
Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message r=k88hudson

https://hg.mozilla.org/mozilla-central/rev/089d52d6ad36

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I have verified this issue and is no longer reproducible on Latest Firefox Nightly 71.0a1 (Build ID: 20190902213933) and Firefox Beta 70.0b3 (Build ID: 20190902191027) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The "info" and "Dismiss" buttons are accessible through keyboard navigation. However, the "Dismiss" button does not have a focus effect although is selected and I logged the following issue: bug 1554739.

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: