Preview - mousing from the token to the popup closes the popup
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(firefox-esr60 unaffected, firefox67 unaffected, firefox68 wontfix, firefox69 fixed)
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | wontfix |
firefox69 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
I think we recently regressed a popup feature - where moving from the token to the popup should keep the popup open.
STR:
- hover on a token
- move your mouse from the token to the popup
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
this bug accidentally regressed it - bug 1549777
I thought this would have saved us - https://phabricator.services.mozilla.com/D30301
Assignee | ||
Updated•5 years ago
|
The preview unrenders because of the whitespace in between the token and the preview popup. This patch moves the preview popup closer to the token and changes the conditions for unrendering the preview.
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Backed out for node debugger perma failures.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248870684&repo=autoland&lineNumber=162
[task 2019-05-29T02:22:57.936Z] TEST START | Flow
[task 2019-05-29T02:23:12.085Z] Error ---------------------------------------------------------------------- src/components/Editor/Preview/Popup.js:92:8
[task 2019-05-29T02:23:12.085Z]
[task 2019-05-29T02:23:12.085Z] Property $popover
is missing in HTMLDivElement
[1].
[task 2019-05-29T02:23:12.085Z]
[task 2019-05-29T02:23:12.085Z] src/components/Editor/Preview/Popup.js:92:8
[task 2019-05-29T02:23:12.085Z] 92| (this.popover.$popover && this.popover.$popover.matches(":hover")) ||
[task 2019-05-29T02:23:12.085Z] ^^^^^^^^^^^^^^^^^^^^^
[task 2019-05-29T02:23:12.085Z]
[task 2019-05-29T02:23:12.085Z] References:
[task 2019-05-29T02:23:12.085Z] src/components/Editor/Preview/Popup.js:58:13
[task 2019-05-29T02:23:12.085Z] 58| popover: ?HTMLDivElement;
[task 2019-05-29T02:23:12.085Z] ^^^^^^^^^^^^^^ [1]
[task 2019-05-29T02:23:12.088Z] Found 7 errors
[task 2019-05-29T02:23:12.088Z]
[task 2019-05-29T02:23:26.267Z] TEST-UNEXPECTED-FAIL flow | property $popover
is missing in HTMLDivElement
[1].
[task 2019-05-29T02:23:26.267Z] TEST-UNEXPECTED-FAIL flow | property $popover
is missing in null or undefined [1].
[task 2019-05-29T02:23:26.267Z] TEST-UNEXPECTED-FAIL flow | Cannot call this.popover.$popover.matches
because property matches
is missing in property $popover
of unknown type [1].
[task 2019-05-29T02:23:26.268Z] TEST-UNEXPECTED-FAIL flow | property $tooltip
is missing in HTMLDivElement
[1].
[task 2019-05-29T02:23:26.268Z] TEST-UNEXPECTED-FAIL flow | property $tooltip
is missing in null or undefined [1].
[task 2019-05-29T02:23:26.268Z] TEST-UNEXPECTED-FAIL flow | Cannot call this.popover.$tooltip.matches
because property matches
is missing in property $tooltip
of unknown type [1].
[task 2019-05-29T02:23:26.268Z] TEST-UNEXPECTED-FAIL flow | Cannot assign a
to this.popover
because Popover
[1] is incompatible with HTMLDivElement
[2].
[task 2019-05-29T02:23:26.268Z] TEST START | Eslint
[task 2019-05-29T02:24:11.034Z] yarn run v1.9.4
[task 2019-05-29T02:24:11.034Z] $ eslint .js "src/**/.js" "packages//src/**/.js" --fix
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/ProjectSearch.js
[task 2019-05-29T02:24:11.034Z] 120:7 warning Do not use setState in componentDidUpdate react/no-did-update-set-state
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/SecondaryPanes/Breakpoints/Breakpoint.js
[task 2019-05-29T02:24:11.034Z] 183:17 warning Dangerous property 'dangerouslySetInnerHTML' found react/no-danger
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/SecondaryPanes/WhyPaused.js
[task 2019-05-29T02:24:11.034Z] 44:7 warning Do not use setState in componentDidUpdate react/no-did-update-set-state
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/shared/Popover.js
[task 2019-05-29T02:24:11.034Z] 57:7 warning Do not use setState in componentDidMount react/no-did-mount-set-state
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/basic.js
[task 2019-05-29T02:24:11.034Z] 346:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z] 376:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/expand.js
[task 2019-05-29T02:24:11.034Z] 190:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/release-actors.js
[task 2019-05-29T02:24:11.034Z] 75:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/utils/make-numerical-buckets.js
[task 2019-05-29T02:24:11.034Z] 31:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z] 49:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js
[task 2019-05-29T02:24:11.034Z] 600:1 warning Skipped test suite jest/no-disabled-tests
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] ✖ 11 problems (0 errors, 11 warnings)
[task 2019-05-29T02:24:11.034Z]
[task 2019-05-29T02:24:11.034Z] Done in 44.35s.
Backout: https://hg.mozilla.org/integration/autoland/rev/4ff46098b35360c47ad8aa0d890fce8e33c90712
Assignee | ||
Comment 5•5 years ago
|
||
The preview unrenders because of the whitespace in between the token and the preview popup. This patch moves the preview popup closer to the token and changes the conditions for unrendering the preview.
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d01bd4d9e632
https://hg.mozilla.org/mozilla-central/rev/652a6bf1c627
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Hi Jason, is this something we should consider backporting to Beta or can it ride the trains?
Updated•5 years ago
|
Updated•3 years ago
|
Description
•