Closed
Bug 1551696
Opened 5 years ago
Closed 5 years ago
Add branding logo and icons for edit, delete, and reveal buttons
Categories
(Firefox :: about:logins, enhancement, P1)
Firefox
about:logins
Tracking
()
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline] )
Attachments
(7 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
The Lockwise logo should be shown on branded builds, and the edit, delete, and reveal button should include icons (reveal should only show an icon, no text).
Flags: qe-verify-
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
I wasn't sure what we should show in the case of unofficial builds. Curently the logo is just hidden for those builds.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c03af91db04
Remove type=text/css from style references since its not necessary. r=MattN
https://hg.mozilla.org/integration/autoland/rev/71171349b87c
Fix a color for the deemphasized text of the field-label. r=MattN
https://hg.mozilla.org/integration/autoland/rev/b8540f8b95a6
Add branded logo for official builds. r=MattN
https://hg.mozilla.org/integration/autoland/rev/15df555adc39
Add delete icon. r=MattN
https://hg.mozilla.org/integration/autoland/rev/034521c95944
Add edit icon. r=MattN
https://hg.mozilla.org/integration/autoland/rev/871756833dc4
Change reveal-button to a checkbox. r=MattN,Pike
https://hg.mozilla.org/integration/autoland/rev/8189bd3d8078
Add reveal icon. r=MattN
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c03af91db04
https://hg.mozilla.org/mozilla-central/rev/71171349b87c
https://hg.mozilla.org/mozilla-central/rev/b8540f8b95a6
https://hg.mozilla.org/mozilla-central/rev/15df555adc39
https://hg.mozilla.org/mozilla-central/rev/034521c95944
https://hg.mozilla.org/mozilla-central/rev/871756833dc4
https://hg.mozilla.org/mozilla-central/rev/8189bd3d8078
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
Whiteboard: [passwords:management] [skyline]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla68 → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•