Closed Bug 1551758 Opened 6 years ago Closed 5 years ago

Form submission reentrancy protection for 'submit' and 'invalid' event

Categories

(Core :: DOM: Forms, defect, P3)

Product:
Core
Component:
DOM: Forms
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: tkent, Assigned: jdai)

References

(
URL
)

Details

Attachments

(3 files)

Bug 1551758 - Centralize form submission;
(deleted), text/x-phabricator-request
Details
Bug 1551758 - Update spec link and comments for CheckValidFormSubmission and CheckFormValidity;
(deleted), text/x-phabricator-request
Details
Bug 1551758 - Form submission reentrancy protection for 'submit' and 'invalid' event;
(deleted), text/x-phabricator-request
Details

HTML Specification PR: https://github.com/whatwg/html/pull/4621
Test PR: https://github.com/web-platform-tests/wpt/pull/16811

Firefox fails with the second test case in html/semantics/forms/form-submission-0/form-submission-algorithm.html . Firefox's <form> implementation must have a flag to prevent reentrancy by 'submit' event. The flag should be expanded to cover form interactive validation.

Component: General → DOM: Core & HTML
Product: Firefox → Core
URL: https://github.com/whatwg/html/pull/4621
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

Put into my queue, I'll take care of this.

Assignee: nobody → jdai
Status: NEW → ASSIGNED

Use mIsFiringSubmissionEvents to implement firing submission events boolean in specification.

Attachment #9108981 - Attachment description: Bug 1551758 - Add spec link for CheckValidFormSubmission and CheckFormValidity; → Bug 1551758 - Update spec link and comments for CheckValidFormSubmission and CheckFormValidity;
Attachment #9108980 - Attachment description: Bug 1551758 - Form submission reentrancy protection for 'invalid' event; → Bug 1551758 - Centralize form submission;
Pushed by jdai@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ffaf0da08d9 Centralize form submission; r=smaug https://hg.mozilla.org/integration/autoland/rev/295015e6e79b Update spec link and comments for CheckValidFormSubmission and CheckFormValidity; r=smaug https://hg.mozilla.org/integration/autoland/rev/7f73f8d6d3b1 Form submission reentrancy protection for 'submit' and 'invalid' event; r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20338 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging

(In reply to Arthur Iakab [arthur_iakab] from comment #10)

Backed out 3 changesets (bug 1551758) for causing wpt failures on form-submission-algorithm.html. CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/b5884cc109b5ff0772f37f5973045f7a9d68c75e

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7f73f8d6d3b1f744d864f7f30a9009e772c5376a&searchStr=wpt

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=277190159&repo=autoland

John can you please take a look?

It's because form-submission-algorithm.html WPT just updated. It required some merge with my change for form-submission-algorithm.html.ini file.

TEST-UNEXPECTED-FAIL | /html/semantics/forms/form-submission-0/form-submission-algorithm.html | firing an event named submit; form.requestSubmit() - promise_test: Unhandled rejection with value: object "TypeError: form.requestSubmit is not a function"
Flags: needinfo?(jdai)
Pushed by jdai@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7513b1aebd0 Centralize form submission; r=smaug https://hg.mozilla.org/integration/autoland/rev/95b50e3a1f8c Update spec link and comments for CheckValidFormSubmission and CheckFormValidity; r=smaug https://hg.mozilla.org/integration/autoland/rev/1f77dd98df61 Form submission reentrancy protection for 'submit' and 'invalid' event; r=smaug
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/d7513b1aebd0
https://hg.mozilla.org/mozilla-central/rev/95b50e3a1f8c
https://hg.mozilla.org/mozilla-central/rev/1f77dd98df61

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Regressions: 1598684
Upstream PR merged by moz-wptsync-bot
Component: DOM: Core & HTML → DOM: Forms
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: