Closed Bug 1552182 Opened 5 years ago Closed 5 years ago

OTR chat: remove helper function protocolName() in OTR.jsm, or replace it with a better API

Categories

(Chat Core :: Security: OTR, defect)

Product:
Chat Core
Component:
Security: OTR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Unassigned)

References

Details

The discussion in https://phabricator.services.mozilla.com/D17691 suggested that function protocolName() should be replaced with something else.

But we currently don't understand yet exactly what it should be replaced with, because it hasn't been researched what input exactly it gets, and why we need to transform it for user interface display.

Furthermore, the only place its being used is for a UI that has been proposed to be removed, see bug 1552177.

So, I suggest that this small helper function doesn't deserve a lot of attention right now... Rather, as a first step, we should postpone it, and we should see if it can indeed by obsoleted and removed, because of bug 1552177.

removed as part of bug 1550487.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: General → Security: OTR
You need to log in before you can comment on or make changes to this bug.