Closed
Bug 1552184
Opened 5 years ago
Closed 5 years ago
[about:addons] Handle detail load when add-on not found
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla69
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Loading the detail view directly for an add-on that doesn't exist should go to the discovery view.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5915e723b2c3
Go to discover if detail view add-on can't be found r=rpl
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9065414 [details]
Bug 1552184 - Go to discover if detail view add-on can't be found r?rpl
Beta/Release Uplift Approval Request
- User impact if declined: Re-opening or restoring an about:addons tab for an add-on that is no longer installed results in a blank page.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small change with test coverage
- String changes made/needed:
Attachment #9065414 -
Flags: approval-mozilla-beta?
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9065414 [details]
Bug 1552184 - Go to discover if detail view add-on can't be found r?rpl
fix for about:addons, approved for 68.0b9
Attachment #9065414 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 7•5 years ago
|
||
In the uplift request there is stated that there is no need of manual qa. If that is true can you please mark this as "qe-verify-"? If not can you please provide some instructions for this issue to be manually tested?
Flags: needinfo?(mstriemer)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(mstriemer) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•