Closed Bug 1552195 Opened 5 years ago Closed 5 years ago

Support the escape button for closing all modals

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Status
firefox69 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

(Keywords: access, github-merged)

Attachments

(1 file)

Add support for closing modals using the esc key as well as clicking the modal backdrop.

Thanks for filing, Emily! Is this something you're actively working on or just wanted to make sure there was a bug to capture this work?

Flags: needinfo?(emcminn)

(In reply to Jessilyn Davis from comment #1)

Thanks for filing, Emily! Is this something you're actively working on or just wanted to make sure there was a bug to capture this work?

Hi Jessilyn,

I've been working on the a11y linting for Activity-stream, so as I do that I've been filing bugs for accessibility improvements. For now it's just to make sure there's a bug to capture the work, though I may pick them up later if I can!
Bug 1553234, adding aria-expanded to collapsible sections, is another one.

Flags: needinfo?(emcminn)
Assignee: nobody → emcminn
Blocks: 1554739
Attached file GitHub Pull Request (deleted) —
Iteration: --- → 69.2 - May 27 - Jun 9
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1555507

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190603160429) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now the modals can be closed using the "Esc" key.

Status: RESOLVED → VERIFIED
No longer blocks: pocket-newtab-69
Component: Activity Streams: Newtab → New Tab Page
Regressions: 1561660
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: