Sluggish opening for Go to File search
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: Harald, Assigned: davidwalsh)
References
(Blocks 2 open bugs)
Details
(Keywords: good-first-bug, Whiteboard: [debugger-mvp])
Attachments
(2 files, 1 obsolete file)
Sluggish animation
What were you doing?
- Cmd-P in the Debugger
What happened?
Sluggish animation
What should have happened?
Instant and smooth feedback.
Anything else we should know?
Profile doesn't do anything expensive: https://perfht.ml/2VvBjML , this is just about fixing the animation.
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
Since this probably mostly CSS and React, marking it gfb. Remove if this wasn't right :)
|
||
Comment 2•5 years ago
|
||
Not sure if I'll have the time, but is there a guide somewhere on how to setup everything if I'd like to try and fix this myself?
Hey @piotrpalek, have you built Mozilla central and set up Phabricator yet? If not, you could check out https://docs.firefox-dev.tools/
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e43b59849492 Improve Quick Open animation r=jlast
|
||
Comment 6•5 years ago
|
||
Backed out for debugger failure.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254451029&repo=autoland&lineNumber=1199
[task 2019-07-02T17:31:12.084Z] Snapshot Summary
[task 2019-07-02T17:31:12.084Z] › 10 snapshots failed from 1 test suite. Inspect your code changes or run yarn run test-ci -u to update them.
[task 2019-07-02T17:31:12.084Z]
[task 2019-07-02T17:31:12.084Z] Test Suites: 1 failed, 204 passed, 205 total
[task 2019-07-02T17:31:12.084Z] Tests: 10 failed, 8 skipped, 1726 passed, 1744 total
[task 2019-07-02T17:31:12.084Z] Snapshots: 10 failed, 430 passed, 440 total
[task 2019-07-02T17:31:12.084Z] Time: 58.192s
[task 2019-07-02T17:31:12.084Z] Ran all test suites in 5 projects.
[task 2019-07-02T17:31:12.084Z] error Command failed with exit code 1.
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › Basic render with mount
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › Basic render with mount & searchType = functions
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › Basic render with mount & searchType = variables
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › updateResults on enable
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › Simple goto search query = :abc & searchType = goto
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › showErrorEmoji › true when no count + query
[task 2019-07-02T17:31:12.084Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › showErrorEmoji › false when count + query
[task 2019-07-02T17:31:12.085Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › showErrorEmoji › false when no query
[task 2019-07-02T17:31:12.085Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › showErrorEmoji › false when goto numeric ':2222'
[task 2019-07-02T17:31:12.085Z] TEST-UNEXPECTED-FAIL jest | ● QuickOpenModal › showErrorEmoji › true when goto not numeric ':22k22'
[task 2019-07-02T17:31:12.085Z] TEST START | Stylelint
Backout: https://hg.mozilla.org/integration/autoland/rev/0b05df89cef54fb4bed9925ed0b18ff9fbb3907b
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29a549042edf Improve search bar performance in debugger r=jlast
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
Description
•