Closed Bug 1552387 Opened 6 years ago Closed 6 years ago

Web Animations leaks memory when applied to non HTML/SVG elements

Categories

(Core :: DOM: Animation, defect, P3)

Product:
Core
Component:
DOM: Animation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

Bug 1552387 - Traverse and unlink EffectSet properties on non-HTML/SVG elements too; r?hiro
(deleted), text/x-phabricator-request
Details

Because we only traverse and unlink elements that pass the if (tmp->IsHTMLElement() || tmp->IsSVGElement()) { condition.

The tests added in this patch do not fail any of their assertions with or
without the code changes in this patch. However, without the code changes in
this patch they will both fail due to reported memory leaks.

Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eeb6dd82b7c1 Traverse and unlink EffectSet properties on non-HTML/SVG elements too; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16893 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/eeb6dd82b7c1

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: