Closed
Bug 1552535
Opened 6 years ago
Closed 6 years ago
Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox67 unaffected, firefox68 fixed, firefox69 fixed)
RESOLVED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | unaffected |
| firefox68 | --- | fixed |
| firefox69 | --- | fixed |
People
(Reporter: standard8, Assigned: andrei.a.lazar)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [bcs:p1])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Bug 1541423 added a line of code:
let isApp = request.principal.appId !== Ci.nsIScriptSecurityManager.NO_APP_ID && request.principal.appId !== Ci.nsIScriptSecurityManager.UNKNOWN_APP_ID;
However, NO_APP_ID and UNKNOWN_APP_ID were removed in bug 1320404 (after that one was started). So they're only resolving to undefined.
I'm unsure as to the effects here, but this seems wrong.
Flags: needinfo?(jhofmann)
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → andrei.a.lazar
Flags: needinfo?(jhofmann)
|
||
Updated•6 years ago
|
status-firefox67:
--- → unaffected
status-firefox68:
--- → affected
status-firefox69:
--- → affected
Keywords: regression
|
|
Assignee | |
Comment 1•6 years ago
|
||
Removed variable that resolved to undefined.
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/423af5a3c7e2
Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined r=VladBaicu
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
|
Assignee | |
Comment 5•6 years ago
|
||
Comment on attachment 9066691 [details]
Bug 1552535 Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined r=VladBaicu
Beta/Release Uplift Approval Request
- User impact if declined: This may cause a lot of regressions if it is not uplifted.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is low risk because we removed unused code.
- String changes made/needed:
Flags: needinfo?(andrei.a.lazar)
Attachment #9066691 -
Flags: approval-mozilla-beta?
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9066691 [details]
Bug 1552535 Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined r=VladBaicu
approved for beta68
Attachment #9066691 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•