Closed
Bug 1553210
Opened 5 years ago
Closed 5 years ago
"Remove All Breakpoints" should clear pending breakpoints
Categories
(DevTools :: Debugger, enhancement, P2)
DevTools
Debugger
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jlast, Assigned: obulat)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files, 2 obsolete files)
When the user selects "Remove All Breakpoints" it should wipe all of the save breakpoints. This will make it easy for users to stop seeing phantom breakpoints.
Reporter | ||
Updated•5 years ago
|
Priority: -- → P2
Reporter | ||
Updated•5 years ago
|
Blocks: dbg-breakpoint
Reporter | ||
Comment 1•5 years ago
|
||
export function removeAllBreakpoints(cx: Context) {
return async ({ dispatch, getState }: ThunkArgs) => {
const breakpointList = getBreakpointsList(getState());
- return Promise.all(
+ await Promise.all(
breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
);
+
+ // I think we should also clear all the pending breakpoints as well.
};
Keywords: good-first-bug
Assignee | ||
Comment 2•5 years ago
|
||
I would like to try tackle this.
Would something like this work?
const breakpointList = getBreakpointsList(getState()).concat(getPendingBreakpointList(getState()));
return Promise.all(
breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
);
Flags: needinfo?(jlaster)
Reporter | ||
Comment 3•5 years ago
|
||
hmm, i'm not sure what the best way to clear the pending breakpoint list. but either way, it is yours :)
Flags: needinfo?(jlaster)
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → obulat
Assignee | ||
Comment 4•5 years ago
|
||
Add action for clearing pending breakpoints
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Attachment #9071093 -
Attachment description: Address revision issues: add tests → Bug 1553210 - Implement clearing pending breakpoints and add tests. r=jlast
Updated•5 years ago
|
Attachment #9068289 -
Attachment is obsolete: true
Assignee | ||
Comment 6•5 years ago
|
||
Updated•5 years ago
|
Attachment #9072426 -
Attachment is obsolete: true
Reporter | ||
Comment 7•5 years ago
|
||
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d506ae7fd6b
Implement clearing pending breakpoints and add tests. r=davidwalsh
Comment 9•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•