WebRender currently does not collect KeyPress telemetry
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox67 | --- | wontfix |
| firefox68 | --- | fixed |
| firefox69 | --- | fixed |
People
(Reporter: bas.schouten, Assigned: barret)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
This was implement for other platforms in bug 1506537. The work to make this work on WebRender was never done, which means we currently do not have KeyPress telemetry for machines where WebRender is enabled.
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Some time ago (bug 819791), InfallibleTArray and nsTArray become equivalent, so
continuing to use InfallibleTArray here will just lead to confusion.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Previously we were only registering CompositionPayloads with LayerManagers
and ignoring WebRender altogether. We now thread the CompositionPayload through
to the RenderThread. This allows us to record composition metadata in profiles
and record KeyPress telemetry in WebRender.
Depends on D32059
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Some time ago (bug 819791), InfallibleTArray and nsTArray become equivalent, so
continuing to use InfallibleTArray here will just lead to confusion.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D32227
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a8973dc65dc4
https://hg.mozilla.org/mozilla-central/rev/c6cf628d6045
|
|
Assignee | |
Comment 7•5 years ago
|
||
Comment on attachment 9066871 [details]
Bug 1553261 - Clean up some of the CompositionPayload infrastructure r?kats
Beta/Release Uplift Approval Request
- User impact if declined: This will have no user facing impact, but we will miss out on telemetry from users using Web Render.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): These patches introduce additional telemetry recording.
- String changes made/needed:
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
(In reply to Barret Rennie [:brennie] from comment #7)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
Can we at least verify this in about:telemetry or something?
|
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9066871 [details]
Bug 1553261 - Clean up some of the CompositionPayload infrastructure r?kats
add missing KEYPRESS_PRESENT_LATENCY telemetry when using webrender, approved for 68.0b7
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 10•5 years ago
|
||
:jcristau, I can verify that the telemetry is recorded in about:telemetry in nightly.
|
||
Comment 11•5 years ago
|
||
| bugherder uplift | ||
Description
•