Closed Bug 1553617 Opened 5 years ago Closed 5 years ago

[de-xbl] convert the doubleimage-toolbarbutton + todaypane-toolbarbutton bindings

Categories

(Calendar :: General, task)

Product:
Calendar
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 69.0

People

(Reporter: mkmelin, Assigned: aleca)

References

Details

Attachments

(1 file, 1 obsolete file)

dexbl-doubleimage-todaypane.patch
(deleted), patch
aleca
: review+
Details | Diff | Splinter Review

Convert the doubleimage-toolbarbutton binding and todaypane-toolbarbutton which inherits from it.

https://searchfox.org/comm-central/rev/e649e2651e47fd724406b4b48d075e77e2ed9370/calendar/base/content/widgets/calendar-widgets.xml#19

Only used at one place: https://searchfox.org/comm-central/rev/e649e2651e47fd724406b4b48d075e77e2ed9370/calendar/lightning/content/messenger-overlay-sidebar.xul#355

I think it probably makes sense to just convert this to a normal toolbarbutton and add JavaScript to set up the date of it.

Attached patch dexbl-doubleimage-todaypane.patch (obsolete) (deleted) — — Splinter Review
Attachment #9067144 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9067144 [details] [diff] [review] dexbl-doubleimage-todaypane.patch Review of attachment 9067144 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9067144 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed

Oopsie, that slipped away, sorry about that.
Uploading an updated patch right now.

Attachment #9067144 - Attachment is obsolete: true
Attachment #9067192 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6b0fd637981a
de-xbl doubleimage and todaypane toolbarbutton. r=mkmelin,jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

We need 7.1.

Flags: needinfo?(philipp)
Target Milestone: --- → 7.0
Flags: needinfo?(philipp)
Target Milestone: 7.0 → 7.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: