Closed Bug 1553836 Opened 6 years ago Closed 5 years ago

Cmd/Ctrl+A selects the entire panel content so it's hard to copy just a response payload for example

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1621914

People

(Reporter: pbro, Assigned: miker)

References

(Blocks 1 open bug)

Details

(Whiteboard: [dt-q])

Attachments

(1 file)

Steps to reproduce:

  • open the netmonitor
  • load any webpage so some requests are displayed
  • click on one of the html, css or js requests
  • in the sidebar, under the response tab, click in the response payload source code
  • press cmd+A (on mac) or ctrl+A (on windows/linux) to select the text

Expected: only the text from that response is selected.
Actual: all of the text inside the entire panel is selected.

One alternative is to right-click on the request in the graph and choose copy response from there, but it's less intuitive.

It's not only a problem of the response tab, the same happens everywhere in that tool.
It seems like it would be good to catch this shortcut and do what's right, per tab.

Attached image Screenshot 2019-05-23 at 16.25.56.png (deleted) —

Honza,

Can you assign this to me?

But I'm curious. Are shortcuts like this browser specific or system specific? Is there a reason why a 'copy' button wouldn't suffice for copying the payload instead of modifying shortcuts?

Thanks!

Flags: needinfo?(odvarko)

This might be a problem with focus or with not stoping the event propagation. Note that it works in some cases:

This works for me:

  1. Select a JS request
  2. Open the Response panel
  3. Click in the response panel and place the cursor next to a bracket (can be standard or curly bracket). It should be highlighted together with the other matching bracket. Consequently press Ctrl+A -> it works for me

You can also try the Debugger panel (it uses Code Mirror too) - the debugger panel works for me in all cases.

Honza

Assignee: nobody → lloanalas
Flags: needinfo?(odvarko)

Thanks Honza,

For the sake of posterity and keeping others in the loop. I'm still working on this bug, but another bug I'm working on has taken my attention from this for a bit.

Thanks!

Unassign Lloan in favor of fixing bug 1559347
Honza

Assignee: lloanalas → nobody

We could make things a bit cleaner by making sure text in the toolbar and footer are not selectable (probably with -moz-user-select: none in CSS). Then, even if we don't handle Cmd+A correctly or perfectly, the selection might still be usable.

On my Mac, I can't even highlight text in the payload text panel. When I do, the text immediately un-highlights when I release my mouse button. There's no way at all that I can find to copy text from the request payload area.

(In reply to Eric Shepherd [:sheppy] from comment #8)

On my Mac, I can't even highlight text in the payload text panel. When I do, the text immediately un-highlights when I release my mouse button. There's no way at all that I can find to copy text from the request payload area.

I see this issue on Win10 too.
Honza

Whiteboard: [dt-q]

One solution for this could be to render the response-payload-text within an iframe.

Honza

Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED

This has been fixed by bug 1621914

Honza

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: