Open
Bug 1553918
Opened 5 years ago
Updated 2 years ago
AboutPrivateBrowsingHandler.jsm not correctly unregistering message listeners
Categories
(Firefox :: Private Browsing, defect, P3)
Firefox
Private Browsing
Tracking
()
NEW
People
(Reporter: johannh, Unassigned)
References
(Regression)
Details
(Keywords: regression)
This happens here: https://searchfox.org/mozilla-central/rev/952521e6164ddffa3f34bc8cfa5a81afc5b859c4/browser/components/about/AboutPrivateBrowsingHandler.jsm#23,33
We need to cache the bound functions to be able to unregister them, and line 33 doesn't even pass anything.
We should probably also change https://searchfox.org/mozilla-central/rev/662de518b1686c4769320d6b8825ce4864c4eda0/toolkit/components/remotepagemanager/RemotePageManagerParent.jsm#135 to throw an error if we didn't have the callback that was passed registered, or at the very least if nothing is passed.
Comment 1•5 years ago
|
||
Fortunately this is the parent process and on shutdown, so really the code could probably just be removed?
Updated•3 years ago
|
Has Regression Range: --- → yes
Updated•3 years ago
|
Keywords: regression
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•