Closed
Bug 1553972
Opened 5 years ago
Closed 5 years ago
make --with-pgo-profile-path take a directory
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox68 fixed, firefox69 fixed)
RESOLVED
FIXED
mozilla69
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
e10s profiling or IR-based PGO instrumentation will both produce
multiple .profraw files that need to be handled in some way. Since
clang's -fprofile-generate option takes a directory, it seems fitting
to make --with-pgo-profile-path mirror that by taking a directory, and
letting merge_profdata.py deal with whatever files it might find in
said directory.
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99dfff71a4ca
make --with-pgo-profile-path take a directory; r=nalexander
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Comment on attachment 9067181 [details]
Bug 1553972 - make --with-pgo-profile-path take a directory; r=#build
Beta/Release Uplift Approval Request
- User impact if declined: Fennec Beta and Release won't have PGO'd builds
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1553065
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Tested at https://bugzilla.mozilla.org/show_bug.cgi?id=1553065#c23
- String changes made/needed: None
Attachment #9067181 -
Flags: approval-mozilla-beta?
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9067181 [details]
Bug 1553972 - make --with-pgo-profile-path take a directory; r=#build
Prerequisite patch for bug 1553065. Approved for 68.0b11.
Attachment #9067181 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
status-firefox68:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•