Enable some ESLint rules for more of layout/
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
As part of rolling out ESLint across the tree, I'd like to enable it for the layout/ directory.
The first stage to this is enabling ESLint on the directories, and disabling the rules that fail. This gives us the benefit of at least syntactical checks to begin with plus some rules being enabled.
Some of the disabled rules are style related, those we'll defer to later as we're looking into rolling out js formatting across the tree (and might as well take the reformatting hit one-time).
For enabling the other rules I will file mentored follow-up bug(s) after this lands.
The code changes I'm landing in this bug are for supporting the ESLint rule no-shadow. These were fairly simple there was just quite a few of them. There were one or two places I whitelisted, as it didn't make sense to fix the whole file.
|
Assignee | |
Comment 1•5 years ago
|
||
Depends on D32495
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9dcf4317c50c
https://hg.mozilla.org/mozilla-central/rev/2283a3e7f2de
|
|
Assignee | |
Updated•5 years ago
|
Description
•