Read GeckoView configuration file in release builds when package is the current Android "debug-app"
Categories
(GeckoView :: General, defect)
Tracking
(firefox68 fixed, firefox69 fixed)
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Bug 1533385 taught GeckoView to read configuration from a file. But right now, release APKs don't read that configuration: see the documentation at See https://mozilla.github.io/geckoview/tutorials/automation.html#enabling-reading-configuration-from-a-file-for-release-builds. However, Android has a flag -- the "debug-app" flag -- that Chrome uses to control this configuration file behaviour, and this ticket tracks making GeckoView do that too.
In particular, harnesses can use am {set,clear}-debug-app ... (see https://developer.android.com/studio/command-line/adb) to set the flag, and then it can be read in GeckoView using https://developer.android.com/reference/android/provider/Settings.Global.html#DEBUG_APP.
|
Assignee | |
Comment 1•6 years ago
|
||
Bug 1533385 taught GeckoView to read configuration from a file. But
right now, release APKs don't read that configuration: see the
documentation at See
https://mozilla.github.io/geckoview/tutorials/automation.html#enabling-reading-configuration-from-a-file-for-release-builds.
However, Android has a flag -- the "debug_app" flag -- that Chrome
uses to control this configuration file behaviour, and this commit
makes GeckoView uses that flag as well.
To use this, invoke adb shell am set-debug-app --persistent PACKAGE
(see https://developer.android.com/studio/command-line/adb).
|
||
Updated•6 years ago
|
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 9067405 [details]
Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?snorp
Beta/Release Uplift Approval Request
- User impact if declined: It will be difficult to control GeckoView parameters in automation for Fenix, which is planning to ship on GV 68.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Worst case, this crashes in some way in the wild. It's a JVM crash, so we should get very good stacktraces for such crashes.
- String changes made/needed:
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9067405 [details]
Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?snorp
geckoview fix for 68.0b7
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
Description
•