[de-xbl] convert the calendar-category-box binding
Categories
(Calendar :: General, task)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: khushil324)
References
Details
Attachments
(2 files, 1 obsolete file)
Screenshot 2019-06-11 at 2.08.30 PM.png
Convert the calendar-category-box binding
https://searchfox.org/comm-central/rev/5a670c59f9004ef9be4874cfbfe57ec2ef3b260f/calendar/base/content/calendar-view-core.xml#382
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
The gradient color is very light and hard to identify because of the similar background color of calendar-month-day-box-item. Can we change the color of gradient to identify the category type easily?
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 4•5 years ago
|
||
Comment on attachment 9071201 [details] [diff] [review] Bug-1554642_de-xbl_calendar-category-box.patch Review of attachment 9071201 [details] [diff] [review]: ----------------------------------------------------------------- This seems to work the wrong way. It applies the color to all of the event, not just to the (whatever-its-called) category indicator at the right. So if I set vacation to green, the whole event is green and I can't see the text.
|
|
Assignee | |
Comment 5•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #4)
This seems to work the wrong way. It applies the color to all of the event,
not just to the (whatever-its-called) category indicator at the right. So if
I set vacation to green, the whole event is green and I can't see the text.
I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?
|
|
Assignee | |
Comment 6•5 years ago
|
||
(In reply to Khushil Mistry [:khushil324] from comment #5)
I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?
It is working fine on Multiweek but not in the week view. I will update the patch.
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Reporter | |
Comment 8•5 years ago
|
||
Comment on attachment 9073761 [details] [diff] [review] Bug-1554642_de-xbl_calendar-category-box.patch Review of attachment 9073761 [details] [diff] [review]: ----------------------------------------------------------------- Works fine now, thx!
|
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 9•5 years ago
|
||
Khushil, did you have a try run for this? If not, send one off and then get it checked in.
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 12•5 years ago
|
||
Please repeat this try run, it's all orange due to other reasons.
|
|
Assignee | |
Comment 13•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 14•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4cd00a290f7a
[de-xbl] convert the calendar-category-box binding. r=philipp
|
|
||
Updated•5 years ago
|
Description
•