Closed Bug 1555120 Opened 5 years ago Closed 5 years ago

Crash in [@ mozilla::ipc::ContentPrincipalInfo::ContentPrincipalInfo]

Categories

(Core :: DOM: Security, defect)

Product:
Core
Component:
DOM: Security
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: marcia, Assigned: ckerschb)

References

Details

(Keywords: crash, regression, regressionwindow-wanted)

Crash Data

This bug is for crash report bp-e8028a58-027d-4f98-bb0d-5ad5f0190522.

Mac specific regression seen in Nightly 69 as well as Beta 68: https://bit.ly/2K98i7v. 8 crashes in 8 installs in the 7 last days on 69 Nightly.

I put it in IPC but it isn't clear from the stack that is the proper place for it.

Some URLs:

Top 10 frames of crashing thread:

0 XUL mozilla::ipc::ContentPrincipalInfo::ContentPrincipalInfo ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackgroundSharedTypes.h:155
1 XUL mozilla::Maybe<mozilla::dom::IPCServiceWorkerDescriptor>::operator= mfbt/Maybe.h:249
2 XUL mozilla::PProfilerChild::OnChannelClose ipc/ipdl/PProfilerChild.cpp:305
3 XUL mozilla::gmp::GMPVideoi420FrameImpl::CreateEmptyFrame dom/media/gmp/GMPVideoi420FrameImpl.cpp:137
4 XUL void mozilla::MozPromise<mozilla::gmp::GMPServiceChild*, mozilla::MediaResult, true>::Private::Resolve<mozilla::gmp::GMPServiceChild*> xpcom/threads/MozPromise.h:1038
5 XUL mozilla::openPrefFile modules/libpref/Preferences.cpp:4183
6 XUL <name omitted> xpcom/threads/SchedulerGroup.cpp:309
7 XUL mozilla::SharedThreadPool::GetThreadStackSize xpcom/threads/SharedThreadPool.h:55
8 XUL  ipc/glue/BackgroundImpl.cpp:1206
9 XUL mozilla::PrioritizedEventQueue<mozilla::EventQueue>::SizeOfExcludingThis const xpcom/threads/PrioritizedEventQueue.h:91

Maybe a regression from the CSP refactoring? Though it is also present on 68.

Component: IPC → DOM: Security
Flags: needinfo?(jkt)

We just fixed Bug 1553742 which might also have resolved the problem here. I am adding a the bug as a 'see also'. If the crashes keep occuring we need to take a clooser look at this one.

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1553742

The last reported Nightly crash came from a 20190528101320 build, so it looks like bug 1553742 might have indeed helped. Is that something we could safely consider for Beta backport?

Assignee: nobody → ckerschb
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → wontfix
status-firefox68: --- → affected
status-firefox69: affected → fixed
status-firefox-esr60: --- → unaffected
Flags: needinfo?(ckerschb)
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Pretty low volume on 68.

status-firefox68: affected → fix-optional

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

The last reported Nightly crash came from a 20190528101320 build, so it looks like bug 1553742 might have indeed helped. Is that something we could safely consider for Beta backport?

I think we can't, because the code relies on the changes added within Bug 965637, which were only added for 69 - but maybe I am wrong because I can't think straight because of jetlag.

Flags: needinfo?(ckerschb)
You need to log in before you can comment on or make changes to this bug.