Google docs images use blobs
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: nical, Assigned: Gankra)
References
(Blocks 2 open bugs)
Details
(Keywords: perf, perf-alert)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Images in google docs are wrapped in svg elements which causes us to use a blob image and do unecessary work.
It would be good if we could detect that an SVG element only contains elements we support and avoid the blob fallback (in the case of google docs it is a single image).
Assignee | ||
Comment 1•5 years ago
|
||
looked into this and am currently confused because at least highlight-painted-layers seems to think we're not making a blob for google docs images (even though they're still inside an svg)
currently manually confirming the machinery isn't broken and that there indeed is no blob
Assignee | ||
Comment 2•5 years ago
|
||
Ok so it looks like a naive active-layers approach to this one won't work. The svg in question shows up as a transform containing an opaque(?) nsDisplaySVGGeometry, and not an nsDisplayImage as I'd hoped. I'll need to actually dig into the SVG itself to try to do this.
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
:aosmond -- don't bother reviewing that yet, mostly just wanted to test that i had pushing patches up for review properly configured :p
Assignee | ||
Comment 5•5 years ago
|
||
Ok this is ready to land, but I'm holding off until after we cut the beta, so that we have room to test this in nightly.
Comment 7•5 years ago
|
||
Backed out changeset 3a8a36e50541 (Bug 1555356) for reftest failures at pattern-big-image.html.
https://hg.mozilla.org/integration/autoland/rev/d9ce692efa0dedcc6c91a403f6ea6393377321a1
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288802735&repo=autoland&lineNumber=6911
Assignee | ||
Comment 9•5 years ago
|
||
just slightly fuzzier on mac (+2 pixels)
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Backed out changeset 6550b62f1fe7 (Bug 1555356) for causing reftest failures in SVG files.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b442437f440a57ed9d57f82b1facd7d88a1696dd
Pushes with failures:
- https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Creftests%2Ctest-windows10-64-qr%2Fdebug-reftest-e10s-1%2Cr%28r1%29&tochange=65204cac7dc47b303fe7e6234105b9609c12cef0&fromchange=b7672602baaacbed97eef8eb0c8254d7b1cd3ad6&selectedJob=289004045
- https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Creftests%2Ctest-windows10-64-qr%2Fdebug-reftest-e10s-4%2Cr%28r4%29&fromchange=8baaed81dd2949e0797546fa64ca3a09e14f7121&tochange=65204cac7dc47b303fe7e6234105b9609c12cef0&selectedJob=289000621
Failure logs:
Comment 11•5 years ago
|
||
== Change summary for alert #24964 (as of Mon, 17 Feb 2020 12:14:53 GMT) ==
Improvements:
11% tsvgx windows10-64-shippable-qr opt e10s stylo 183.66 -> 163.28
10% tsvgx windows10-64-shippable-qr opt e10s stylo 184.07 -> 165.22
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24964
And the backout:
== Change summary for alert #24960 (as of Mon, 17 Feb 2020 10:47:17 GMT) ==
Regressions:
9% tsvgx windows10-64-shippable-qr opt e10s stylo 170.04 -> 185.89
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24960
Assignee | ||
Comment 12•5 years ago
|
||
Issues from backout:
- minor fuzzy bump on a specific platform
- exposing pre-existing Bug 1616326
For the latter, i'm inclined to mark this test as failing under WR until the root bug is fixed, and pressing along with this patch
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 13•5 years ago
|
||
This is not a regression, the regression in tsvgx was caused by the backout of this patch.
Alexis, did you make a decision about comment 12?
Assignee | ||
Comment 14•5 years ago
|
||
I am currently working on fixing the root issue, it's just a bit of a mess in there.
Assignee | ||
Comment 15•5 years ago
|
||
I believe the patch here is ultimately correct, but Bug 1616326 needs to be fixed before we reland this.
Comment 16•5 years ago
|
||
I've rebased this and did not see any regressions locally (Windows at 100% DPI), with reftest reftest-sanity
, reftest svg
(both enable-webrender
) nor wrench reftest
(-p1). Here's a try run.
Updated•4 years ago
|
Comment 17•4 years ago
|
||
Comment 18•4 years ago
|
||
bugherder |
Comment 19•4 years ago
|
||
== Change summary for alert #25975 (as of Sat, 16 May 2020 10:56:27 GMT) ==
Improvements:
12% raptor-tp6-slides-firefox-cold fcp windows10-64-shippable-qr opt 1,424.58 -> 1,248.33
10% raptor-tp6-slides-firefox-cold fcp linux64-shippable-qr opt 1,381.75 -> 1,247.00
3% raptor-tp6-slides-firefox-cold windows10-64-shippable-qr opt 1,246.98 -> 1,207.00
3% raptor-tp6-slides-firefox-cold linux64-shippable-qr opt 1,290.08 -> 1,257.69
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25975
Comment 20•4 years ago
|
||
== Change summary for alert #25984 (as of Mon, 18 May 2020 05:27:32 GMT) ==
Improvements:
14% tsvgx linux64-shippable-qr opt e10s stylo 247.31 -> 211.67
13% tsvgx linux64-shippable-qr opt e10s stylo 247.31 -> 214.56
6% tsvg_static linux64-shippable-qr opt e10s stylo 42.71 -> 39.95
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25984
Comment 22•4 years ago
|
||
I wonder if we should consider backing this out given the high number of regressions.
Comment 23•4 years ago
|
||
Comment hidden (obsolete) |
Updated•4 years ago
|
Comment 25•4 years ago
|
||
bug 1684625 puts this code path under a pref that disables it. That fixes the regressions. I've checked in some reftests as part of that bug so if this code path is to be re-enabled they'd need to be fixed.
Updated•3 years ago
|
Description
•