WebSocket frame payload preview
Categories
(DevTools :: Netmonitor, defect, P2)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: Honza, Assigned: tanhengyeow)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
It should be possible to inspect selected frame's payload. The payload preview should be located at the bottom of the side panel.
- Support for plain text preview (binary payloads encoded using base64)
- Support for JSON (using TreeView, just like for JSON responses)
Honza
Reporter | ||
Comment 1•5 years ago
|
||
Some pointers:
-
Here is an example of using TreeView to render JS object / JSON
https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/devtools/client/netmonitor/src/components/PropertiesView.js#240 -
Example of SplitBox usage
https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/devtools/client/netmonitor/src/components/MonitorPanel.js#146
Honza
Reporter | ||
Comment 2•5 years ago
|
||
We should also use Accordion [1] component when we render the payload preview. This should be useful especially in cases where we want to display both (1) the raw payload and (2) its formatted version (e.g. JSON).
Honza
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
The Accordion section label can also show size of the payload the same way as we do e.g. for HTTP headers.
Honza
Assignee | ||
Comment 4•5 years ago
|
||
Support WebSocket frame payload preview.
Updated•5 years ago
|
Reporter | ||
Comment 5•5 years ago
|
||
See how to make the style of WS frame payload JSON preview the same as HTTP JSON response. It would be great to share one component that would preview JSON for both, but perhaps we can do it in a follow up.
Reporter | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
Description
•