Closed Bug 1555631 Opened 5 years ago Closed 5 years ago

WebSocket frame payload preview

Categories

(DevTools :: Netmonitor, defect, P2)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Honza, Assigned: tanhengyeow)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

It should be possible to inspect selected frame's payload. The payload preview should be located at the bottom of the side panel.

  • Support for plain text preview (binary payloads encoded using base64)
  • Support for JSON (using TreeView, just like for JSON responses)

Honza

We should also use Accordion [1] component when we render the payload preview. This should be useful especially in cases where we want to display both (1) the raw payload and (2) its formatted version (e.g. JSON).

Honza

[1] https://searchfox.org/mozilla-central/rev/8a990595ce6d5ed07ace2d4d5d86cc69aec90bde/devtools/client/shared/components/Accordion.js#11

Attached image image.png (deleted) —

The Accordion section label can also show size of the payload the same way as we do e.g. for HTTP headers.

Honza

Support WebSocket frame payload preview.

Attachment #9078595 - Attachment description: Bug 1555631 - WebSocket frame payload preview. r=Honza,nchevobbe,fvsch *** Remove .orig files → Bug 1555631 - WebSocket frame payload preview. r=Honza,nchevobbe,fvsch

See how to make the style of WS frame payload JSON preview the same as HTTP JSON response. It would be great to share one component that would preview JSON for both, but perhaps we can do it in a follow up.

Assignee: nobody → odvarko
Assignee: odvarko → E0032242
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c35365b22706 WebSocket frame payload preview. r=Honza,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: