This includes setting the default value of media.peerconnection.mtransport_process and network.process.enabled to true in nightly, as well as ensuring that spi tests are run in CI iff the '-spi' suffix is present (in other words, CI should always stomp the default value of these prefs).

Depends on D33643

Try has some infra failures it looks like, retriggering.

Backed out 2 changesets (Bug 1555792) for Windows 2012 build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C2012%2Cshippable%2Cbuild&fromchange=586b27e0e8114f514b71558620ca849abea9d477&tochange=c5a178862298231ac3c47b6d4631a2df3c6499c6&selectedJob=250464983

Backout link: https://hg.mozilla.org/integration/autoland/rev/de019903849effdf777f3acb56d37ee31b888305

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250464983&repo=autoland&lineNumber=47690

22:15:39 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1559856130/build/src/obj-firefox/browser/tools/mozscreenshots/mozscreenshots/extension'
22:15:42 INFO - mozmake.EXE[2]: Entering directory 'z:/task_1559856130/build/src/obj-firefox'
22:15:42 INFO - z:/task_1559856130/build/src/clang/bin/llvm-profdata.exe merge -o ./merged.profdata ./*.profraw
22:15:42 INFO - error: ./default_6044_random_7401113781408603760_0.profraw: Invalid instrumentation profile data (file header is corrupt)
22:15:42 INFO - Makefile:287: recipe for target 'maybe_clobber_profiledbuild' failed
22:15:42 INFO - mozmake.EXE[2]: *** [maybe_clobber_profiledbuild] Error 1
22:15:42 INFO - mozmake.EXE[2]: Leaving directory 'z:/task_1559856130/build/src/obj-firefox'
22:15:42 INFO - Makefile:186: recipe for target 'profiledbuild' failed
22:15:42 INFO - mozmake.EXE[1]: *** [profiledbuild] Error 2
22:15:42 INFO - client.mk:125: recipe for target 'build' failed
22:15:42 INFO - mozmake.EXE: *** [build] Error 2
22:15:42 INFO - 225 compiler warnings present.
22:15:42 ERROR - Return code: 2
22:15:42 WARNING - setting return code to 2
22:15:42 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
22:15:42 FATAL - Running post_fatal callback...
22:15:42 FATAL - Exiting -1
22:15:42 INFO - [mozharness: 2019-06-06 22:15:42.358000Z] Finished build step (failed)
22:15:42 INFO - Running post-run listener: _parse_build_tests_ccov
22:15:42 INFO - Running post-run listener: _shutdown_sccache
22:15:42 INFO - Running post-run listener: _summarize
22:15:42 ERROR - # TBPL FAILURE #
22:15:42 INFO - [mozharness: 2019-06-06 22:15:42.358000Z] FxDesktopBuild summary:
22:15:42 ERROR - # TBPL FAILURE #
[taskcluster 2019-06-06T22:15:42.376Z] Exit Code: 4294967295
[taskcluster 2019-06-06T22:15:42.376Z] User Time: 15.625ms
[taskcluster 2019-06-06T22:15:42.376Z] Kernel Time: 0s
[taskcluster 2019-06-06T22:15:42.376Z] Wall Time: 42m49.2837397s
[taskcluster 2019-06-06T22:15:42.376Z] Result: FAILED

So I saw this failure on try, but a retrigger cleared it up. I had assumed it was infra, because I haven't touched any c++ code in either of these patches. How would touching prefs.js cause the prof builds to corrupt their profile data, anyway?

I can only observe that the bustages seem to start with your changes and seem to turn green on the backout, sorry, can't think how your changes affect the builds.
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C2012%2Cshippable%2Cbuild&fromchange=586b27e0e8114f514b71558620ca849abea9d477&tochange=c5a178862298231ac3c47b6d4631a2df3c6499c6&selectedJob=250464983

Depends on D33644

Seeing some weird new errors on android pgo now.

Looks like I need to edit this file and add an entry for the socket process?

https://searchfox.org/mozilla-central/rev/227f5329f75bd8b16c6b146a7414598a420260cb/mobile/android/base/AndroidManifest.xml.in#537-552

Depends on D34748

bwc confirmed this won't get done in time for M3, so punting to M4 for now.

Patch looks right to me!

Looks like putting quotes around --setpref values (like this) prevents them from being parsed by some test-scripts (like this). I am fixing the cases that involve our socket process prefs, but all other uses of --setpref probably need to be fixed, or we need to strip out quotes on them.

Edit: Also, the try push in comment 44 has a lot of failures in OS 10.10 debug browser-chrome mochitests; the socket process was running on these tests, but those tests aren't running against a shippable build, which means that at least in some cases default prefs on nightly-only are applied to non-shippable builds. That might be another bug.

Just so I don't lose track of it, this is the baseline for comparisons:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a630530d0bf03f3fe7b8607de22cce3817da9d66

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b74fcf3f52ab3eba0573be754bd18abbc9d1b830

Thanks for the heads up.. though I'm pretty sure at least the fission case is working (due to there being tons of errors everywhere). Maybe Gecko is stripping off the extra quotes in that case though.

Either way, we might as well fix this in the pref parsing function.

Seeing a strange failure in bc9 on OS 10.10 debug. Not sure if that's preexisting, trying to figure that out.

Ok... retriggers are failing here too.

Looks like bug 1459355 is preventing me from retriggering the jobs I need to.

Re-pushing to check out that bc9 failure.

With patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27ad7a69e7d61cfd948d9af66684ec604d0c1345
Without: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b350153705a8df762bb634ea3a18ca02669832b2

Depends on D34885

Depends on D37503

Yeah, those look similar.

Seeing a new failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6b2d44667a55e738ad2038ba02ff10d1436348c&selectedJob=255716958

Right. Retriggers are just getting /dev/nulled for that task, apparently. Awesome.

I did see the same failure yesterday on a different bug, so it is probably a pre-existing intermittent.

Now I get to check talos out. Fun.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=684c220a88887b0569907feb14746421ac6b4881

Retriggering some talos runs. Also, I need to run talos on baseline on try, since talos on try sometimes performs very differently than on m-c.

Baseline talos runs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=55a3bb56e5070be11cd3515e9812fa5a43624730

Talos looks fine.

https://hg.mozilla.org/mozilla-central/rev/e9b36f76244b
https://hg.mozilla.org/mozilla-central/rev/0cb155d5d76a
https://hg.mozilla.org/mozilla-central/rev/c0e887e7fc78
https://hg.mozilla.org/mozilla-central/rev/c4e7dc6befff
https://hg.mozilla.org/mozilla-central/rev/8ec55eb4aed6