Closed Bug 1555867 Opened 5 years ago Closed 5 years ago

Measure how common single children in the rule tree are, and consider not using a hashmap in that case.

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

Bug 1555867 - Add some very basic rule tree stats that can be enabled with trace-level logging. r=heycam
(deleted), text/x-phabricator-request
Details
Bug 1555867 - Inline one child in the rule tree. r=heycam
(deleted), text/x-phabricator-request
Details
Bug 1555867 - Report heap size of rule tree heap allocations as well. r=heycam
(deleted), text/x-phabricator-request
Details

See bug 1554852's discussion.

Flags: needinfo?(emilio)
Blocks: 1555971

This is useful to analyze the shape of the rule tree at a glance.

It is indeed the most common case according to a bit of measurement.

A non-atypical example from GitHub for example:

Rule tree stats:
0 - 340
1 - 1403
2 - 28
3 - 8
4 - 2
6 - 1
7 - 3
8 - 2
12 - 2
14 - 1
41 - 1
45 - 1
67 - 1
68 - 1

Depends on D33350

Flags: needinfo?(emilio)
Blocks: 1555886
Blocks: 1556202
Blocks: 1556412
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f4773f8b9a5 Add some very basic rule tree stats that can be enabled with trace-level logging. r=heycam https://hg.mozilla.org/integration/autoland/rev/d7e316a88009 Inline one child in the rule tree. r=heycam https://hg.mozilla.org/integration/autoland/rev/e48148b2edf7 Report heap size of rule tree heap allocations as well. r=heycam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: