Closed
Bug 1555917
Opened 5 years ago
Closed 5 years ago
Remove more dead code from the exception handler and cleanup the client and minidump analyzer
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The exception handler code still contains a fair amount of useless stuff including:
- The mechanism used to serialize all the crash annotations in a single string
- Unused character-conversion functions
- Overly complicated functions for opening files
This should be cleaned up in preparation for bug 1420363.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
This patch includes multiple changes cleaning up various aspects of the crash
reporter client and exception handler:
- Some Unix-specific code was moved out from the base crashreporter client
code and into the appropriate platform implementation - Functions used to open files in the crashreporter client now accept C++
std::ios
flags instead of unreadable booleans - Useless character conversion routines were removed from the
minidump-analyzer - Crash annotations are not serialized into a huge string anymore every time
they change. They are all written out individually during an exception. WriteEscapedMozCrashReason()
uses the exception-safemy_strlen()
instead
of plainstrlen()
- The Windows-specific DLL-blocklist shutdown was removed from the Linux &
macOS Breakpad callbacks - The
CrashReporterHost
,CrashReporterClient
and
CrashReporterMetadataShmem
classes now takensACString
references
instead ofnsCString
ones since they never modify their contents
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa8fbc9069ea
Exception handler and crash reporter client cleanup r=froydnj
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee | ||
Updated•5 years ago
|
Type: defect → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•