Closed Bug 1556122 Opened 5 years ago Closed 5 years ago

Toolbox buttons are missing inline-toolbox class.

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 69.0
Tracking Flags:
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: arshad, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

1556122-restore-inline-toolbox-class.patch
(deleted), patch
mkmelin
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
1556122-restore-inline-toolbox-class.patch for TB 68
(deleted), patch
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review

inline-toolbox class adds padding to toolbox buttons. One example of such buttons is Save All button in attachment-bar.

Keywords: regression
Regressed by: 1535265

Restoring the inline-toolbox class.

I also remove some more CSS in calendar which is no more used with the toolbox/toolbar removal.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9069169 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9069169 [details] [diff] [review] 1556122-restore-inline-toolbox-class.patch Review of attachment 9069169 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9069169 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Attachment #9069169 - Flags: approval-comm-beta?
Attachment #9069169 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/199071a3bf16
Restore the inline-toolbox class on some <vbox id="*-toolbox">. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0

Patch that applies on TB 68.

Attachment #9069240 - Flags: approval-comm-beta?
Comment on attachment 9069240 [details] [diff] [review] 1556122-restore-inline-toolbox-class.patch for TB 68 Thanks. I've already taken this from try.
Attachment #9069240 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: