Custom elements: implement custom element reaction's formAssociatedCallback
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: jdai, Assigned: edgar)
References
Details
Attachments
(3 files, 4 obsolete files)
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I would like to refactor and clean up custom element callbacks a bit in this bug.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D129139
Assignee | ||
Comment 4•3 years ago
|
||
To make adding new callback a bit easiler.
Depends on D129169
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D129190
Assignee | ||
Comment 6•3 years ago
|
||
Depends on D129191
Assignee | ||
Comment 7•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
Assignee | ||
Comment 9•3 years ago
|
||
We need the refactor/cleanup part to add a new callback, but there are still more things I would need to consider to hook the formAssociated callback. So I am going to move the refactor/cleanup part to bug 1556354 which is simpler to implement, in order to not block other callback implementations, e.g. bug 1556363.
Comment 10•3 years ago
|
||
Comment on attachment 9247052 [details]
Bug 1556352 - Part 1: Merge WebComponents.webidl into CustomElementRegistry.webidl; r=smaug
Revision D129139 was moved to bug 1556354. Setting attachment 9247052 [details] to obsolete.
Comment 11•3 years ago
|
||
Comment on attachment 9247101 [details]
Bug 1556352 - Part 2: Remove unnecessary includes from CustomElementRegistry.h; r=smaug
Revision D129169 was moved to bug 1556354. Setting attachment 9247101 [details] to obsolete.
Comment 12•3 years ago
|
||
Comment on attachment 9247145 [details]
Bug 1556352 - Part 3: Merge LifecycleCallback*Args; r=smaug
Revision D129190 was moved to bug 1556354. Setting attachment 9247145 [details] to obsolete.
Comment 13•3 years ago
|
||
Comment on attachment 9247146 [details]
Bug 1556352 - Part 4: Move CustomElementCallback declaration out of CustomElementRegistry.h; r=smaug
Revision D129191 was moved to bug 1556354. Setting attachment 9247146 [details] to obsolete.
Assignee | ||
Comment 14•3 years ago
|
||
See steps 14 of https://html.spec.whatwg.org/commit-snapshots/3ad5159be8f27e110a70cefadcb50fc45ec21b05/#create-an-element-for-the-token
From spec perspective, FACE needs this in order to enqueue the formAssociated callback
while FACE is inserted into document. Otherwise it would bail out in
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#association-of-controls-and-forms:parser-inserted-flag,
and wouldn't run https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#reset-the-form-owner
steps nor https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-reactions:reset-the-form-owner
From implementation perspective, we don't implement parser inserted flag, but we do
update the form owner from parser. Not doing this would make the subsequent part
which implements formAssociated callback a bit simpler, where we don't need to consider
or handle the case that form owner is set from parser.
Updated•3 years ago
|
Assignee | ||
Comment 15•3 years ago
|
||
Depends on D129197
Comment 16•3 years ago
|
||
Comment 18•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ee2b69cb286c
https://hg.mozilla.org/mozilla-central/rev/ee3956242401
https://hg.mozilla.org/mozilla-central/rev/f423533b66a9
Description
•