Closed Bug 1556571 Opened 5 years ago Closed 5 years ago

Use FJCVTZS for convertDoubleToInt32

Categories

(Core :: JavaScript Engine: JIT, enhancement, P2)

67 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

References

Details

Attachments

(1 file)

With Bug 1555509 landed, we can use FJCVTZS for convertDoubleToInt32 on ARMv8.3 chipsets.

The attached patch detects hardware capabilities using Linux getauxval(AT_HWCAP) which works on both Linux and Android. Windows is left out of the loop, but the systems we're targeting there are still ARMv8.2.

Although I don't have the hardware to test this, and only tested it in a simulator, it is expected to be a massive speedup in math-heavy code, and the primary benefit of ARMv8.

Priority: -- → P2
Pushed by sstangl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5902299b20aa Use FJCVTZS for convertDoubleToInt32. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: