Closed Bug 1556745 Opened 6 years ago Closed 5 years ago

browser_privatebrowsing_about.js times out with fix for bug 1549930

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 72
Iteration:
72.1 - Oct 21 - Nov 3
Tracking Status
firefox72 --- fixed

People

(Reporter: hsivonen, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

browser_privatebrowsing_about.js times out with fix for bug 1549930. See https://treeherder.mozilla.org/#/jobs?repo=try&revision=9af7514ecbcced4213fdcc49ab447f711ec773e1 which contains the patch from bug 1549930 comment 46, so that patch did not resolve the issue.

Assignee: nobody → rrosario
Blocks: 1501747

The priority flag is not set for this bug.
:groovecoder, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(lcrouch)
Attachment #9069671 - Attachment is obsolete: true

I noticed this a while ago whilst I was working on some of the private browsing UI. Eventually got around to testing it on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b16dadc3942364ebb7d82230519533572832c7&selectedJob=273278928

It looks like it perma fails test-verify on most platforms, and at least intermittent on fission on Linux, possibly with the same error.

So I think we should try enabling it everywhere apart from those, and see if any intermittents show up etc. We can file fresh bugs for fixing it for test-verify & fission. For now, something is probably better than nothing.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/349580d635e5 Enable browser_privatebrowsing_about.js on everything apart from test-verify and fission. r=r1cky
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Blocks: 1592544
Assignee: rrosario → standard8
Iteration: --- → 72.1 - Oct 21 - Nov 3
Points: --- → 1
Flags: needinfo?(lcrouch)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: