Zooming with ctrl-wheel_scroll works on text but not other areas inside a button
Categories
(Core :: DOM: Events, defect, P3)
Tracking
()
People
(Reporter: Fanolian+BMO, Assigned: smaug)
References
(Regression)
Details
(Keywords: regression, reproducible, testcase)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190604214415
Steps to reproduce
- Open the attached testcase.
- Hover cursor on button text. Zoom with ctrl-wheelscroll.
- Zoom by ctrl-wheelscrolling around the button text in the button.
Actual result
The page zooms if the cursor is on the button text but not on the area around the text.
This creates an undesired effect when the button (text) is pushed away by other elements. Cursor is no longer hovering on text and zoom stops abruptly.
As per bug 1199861, Disabling zoom-by-mousewheel on buttons is intended (bug 65355). This bug report is about the inconsistency of the zooming behaviour inside a button.
Expected result
Either the whole button is not zoomable by mouse wheel like before; or it is zoomable similar to Chrome/Edge. (I do not have Safari for testing.)
Last "good" Nightly (whole button non-zoomable): 2018-12-11
First "bad" Nightly (zoomable on button text): 2018-12-12
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac7f3beb633340c6b3fea25059e8b8aa52b5fc8a&tochange=6f21533f643edc0729216fcc1a2fd6c1b638e536
Further bisection:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f6eebcc14c22762f521fb567a9588963b8720592&tochange=61570c16c2d564c24fab36713fb169c4144453e9
The range includes bug 1089326, bug 1498383, bug 1511388, and bug 1512259.
Marking this bug report as a regression by bug 1089326 as it is the most likely one.
Comment 2•5 years ago
|
||
This is a regression in 66, wontfix for 67.
Comment 3•5 years ago
|
||
This looks like a regression of bug 1089326, maybe Olli has some idea what goes wrong here.
Too late for a fix in 68 but we could still potentially take a patch for 69/70.
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
And disabling zoom "works" only in some rare cases, like when mouse is over the border of input element or textarea etc.
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
(I have a patch for this, just need to find time to write test)
Assignee | ||
Comment 8•5 years ago
|
||
Assignee | ||
Comment 9•5 years ago
|
||
(trying to push the patch to tryserver, but './mach try chooser' is broken for me atm. clobbering and bootstrapping and rebuilding....)
Assignee | ||
Comment 10•5 years ago
|
||
(FWIW, that try chooser error is https://bugzilla.mozilla.org/show_bug.cgi?id=1603561 )
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
Comment 15•5 years ago
|
||
Given that this isn't a new issue, I'm not convinced we need to worry about uplifting this fix to Beta for Fx72, but feel free to nominate if you feel otherwise.
Updated•5 years ago
|
Description
•