Closed
Bug 1557507
Opened 5 years ago
Closed 5 years ago
Default to lld linker for Android builds
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
The current logic is that if the compiler somehow uses gold rather than
BFD ld by default, we let it, but if it uses BFD ld, we default to lld.
When doing Android builds, the compiler finds the linker in the NDK, and
the default ld binary is gold. So we currently end up using fold for
Android builds.
Here, we change the logic such that we use lld when the default linker
the compiler uses is either BFD ld or gold. We can't go with "is not
lld" because the other possible kind, ld64, is what we actually want to
use on mac, since lld doesn't support mach-o fully just yet.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/2d8ad105aac8
Default to lld linker for local builds in more cases. r=nalexander
|
||
Comment 3•5 years ago
|
||
Backed out changeset 2d8ad105aac8 (Bug 1557507) on Glandium's request
Backout link: https://hg.mozilla.org/integration/autoland/rev/2d0d626875641a4abaf0387d1d9c72c0b46cb605
Flags: needinfo?(mh+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5e8d4f11d199
Default to lld linker for local builds in more cases. r=nalexander
|
||
Comment 5•5 years ago
|
||
Type: defect → task
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•