When an extension's manifest.json contains "incognito": "not_allowed", the details page at about:addons should not allow users to modify the preference, and should clearly show that the extension does not have access to private browsing windows.

In XUL about:addons, the text "Not Allowed in Private Windows" is shown.

In HTML about:addons, the private browsing row disappears, without any visual indication that the extension cannot run in private windows.

We should instead show "Not Allowed in Private Windows".

For parity with the XUL about:addons page, this commit adds missing rows
to the details view:

• Bug 1557792 - incognito not_allowed should show "Not Allowed in Private Windows"

• Bug 1551947 - extensions with locked private browsing flag should not
  show inputs to control the flag, but "Requires Access to Private Windows"

Backed out for bc failures on browser_html_detail_view.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f1ee96b07747f7bcab0fb22d0765b9b0bddb9ca6
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=running%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.10%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1010-64-shippable%2Fopt-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&revision=1eba4a29505b3a57006a1325fa64d8d5aecc2682&selectedJob=251812434
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251812434&repo=autoland&lineNumber=6498

https://hg.mozilla.org/mozilla-central/rev/3b5bd41c2585

Do we need to uplift this to 68 or can it ride the trains?

Comment on attachment 9072006 [details]
Bug 1557792 - Show missing private browsing rows in about:addons

Beta/Release Uplift Approval Request

• User impact if declined: For some add-ons (mainly those with incognito: "not_allowed" in their manifest), it is not clear why the private browsing setting cannot be changed from about:addons.

Also (bug 1551947): the private browsing toggle is displayed even if it cannot be changed, for a few special add-ons such as Firefox Color.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): UI-only change in about:addons, fully covered by unit tests.
• String changes made/needed: none

Comment on attachment 9072006 [details]
Bug 1557792 - Show missing private browsing rows in about:addons

fix an issue with the new about:addons, approved for 68.0b14

https://hg.mozilla.org/releases/mozilla-beta/rev/1c3f96c23a84