Closed Bug 1557881 Opened 5 years ago Closed 5 years ago

Sources Tree not showing the Blackbox Item

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: davidwalsh, Assigned: chujunlu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The blackbox icon doesn't show in the sources tree but clicking the pretty print button does show the {} icon.

Type: defect → enhancement
Blocks: dbg-frontend
Priority: -- → P3
Blocks: 1565711
Blocks: 1565713

When working for this bug, I found a related issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1568985. An up-to-date source.isBlackBoxed property is needed. So instead of creating a function similar to hasPrettySource, I get the whole source object and add a blackbox icon based on source.isBlackBoxed. Let me know what you think.

I also added a snapshot test for prettyPrint icon.

No longer blocks: 1565711
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc28b2b49ae7 Update source to get the right isBlackBoxed property r=davidwalsh,jlast
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → chujunlu
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: